try using a fixed hash

Fixes #1

.github/workflows/python_publish.yml

@@ -55,7 +55,7 @@ jobs:
         name: python-package-distributions
         path: dist/
     - name: Publish distribution 📦 to PyPI
-      uses: pypa/gh-action-pypi-publish@release/v1
+      uses: pypa/gh-action-pypi-publish@0ab0b79471669eb3a4d647e625009c62f9f3b241
       with:
         password: ${{ secrets.PYPI_API_TOKEN }}
 
@@ -106,31 +106,31 @@ jobs:
   #       '${{ github.ref_name }}' dist/**
   #       --repo '${{ github.repository }}'
 
-  publish-to-testpypi:
-    name: Publish Python 🐍 distribution 📦 to TestPyPI
-    needs:
-    - build
-    runs-on: ubuntu-latest
+  # publish-to-testpypi:
+  #   name: Publish Python 🐍 distribution 📦 to TestPyPI
+  #   needs:
+  #   - build
+  #   runs-on: ubuntu-latest
 
-    environment:
-      name: testpypi
-      url: https://test.pypi.org/p/goat_monitor
+  #   environment:
+  #     name: testpypi
+  #     url: https://test.pypi.org/p/goat_monitor
 
-    permissions:
-      id-token: write  # IMPORTANT: mandatory for trusted publishing
+  #   permissions:
+  #     id-token: write  # IMPORTANT: mandatory for trusted publishing
 
-    env:
-      RUNNER_TOOL_CACHE: /toolcache  # https://about.gitea.com/resources/tutorials/enable-gitea-actions-cache-to-accelerate-cicd
-      AGENT_TOOLSDIRECTORY: /toolcache  # https://github.com/actions/setup-python/issues/824
+  #   env:
+  #     RUNNER_TOOL_CACHE: /toolcache  # https://about.gitea.com/resources/tutorials/enable-gitea-actions-cache-to-accelerate-cicd
+  #     AGENT_TOOLSDIRECTORY: /toolcache  # https://github.com/actions/setup-python/issues/824
 
-    steps:
-    - name: Download all the dists
-      uses: actions/download-artifact@v3
-      with:
-        name: python-package-distributions
-        path: dist/
-    - name: Publish distribution 📦 to TestPyPI
-      uses: pypa/gh-action-pypi-publish@release/v1
-      with:
-        password: ${{ secrets.TEST_PYPI_API_TOKEN }}
-        repository-url: https://test.pypi.org/legacy/
+  #   steps:
+  #   - name: Download all the dists
+  #     uses: actions/download-artifact@v3
+  #     with:
+  #       name: python-package-distributions
+  #       path: dist/
+  #   - name: Publish distribution 📦 to TestPyPI
+  #     uses: pypa/gh-action-pypi-publish@release/v1
+  #     with:
+  #       password: ${{ secrets.TEST_PYPI_API_TOKEN }}
+  #       repository-url: https://test.pypi.org/legacy/

README.md

@@ -11,7 +11,6 @@ Configuration lives in a TOML file which should have (at a minimum) the followin
 ```toml
 server = "https://gotify.example.com"
 app_token = "app_token_from_gotify"
-
 ```
 
 ## Usage

goat_monitor/goat_monitor.py

@@ -34,7 +34,13 @@ from goat_monitor._version import __version__  # type: ignore
     default=False,
     help="Print version and exit",
 )
-def wrap(command: List[str], config: Path, retries: int, version):
+@click.option(
+    "--dry-run",
+    is_flag=True,
+    default=False,
+    help="Run command without sending any notifications",
+)
+def wrap(command: List[str], config: Path, retries: int, version: bool, dry_run: bool):
     """Wrap an arbitrary command with gotify notifications"""
 
     if version:
@@ -46,13 +52,14 @@ def wrap(command: List[str], config: Path, retries: int, version):
         settings = toml.load(f)
 
     # gotify configuration
-    url = settings["server"]
-    app_token = settings["app_token"]
-    with gotify.Gotify(base_url=url, app_token=app_token) as gotify_connection:
-        # this is just to test configuration.
-        # I don't know how long a gotify connection will stay up so rather than thinking about it
-        # I'm just creating a new one whenever I need to send a message
-        pass
+    if not dry_run:
+        url = settings["server"]
+        app_token = settings["app_token"]
+        with gotify.Gotify(base_url=url, app_token=app_token) as gotify_connection:
+            # this is just to test configuration.
+            # I don't know how long a gotify connection will stay up so rather than thinking about it
+            # I'm just creating a new one whenever I need to send a message
+            pass
 
     if retries == -1:
         retries = np.inf
@@ -62,20 +69,25 @@ def wrap(command: List[str], config: Path, retries: int, version):
     attempt = 0
     while attempt <= retries:
         # run the command
-        result = subprocess.run(
+        with subprocess.Popen(
             " ".join(command),
             shell=True,
             stderr=subprocess.STDOUT,
             stdout=subprocess.PIPE,
-            encoding="utf-8",
-        )
+        ) as proc:
+            stdout = ""
+            while True:
+                c = proc.stdout.read(1)
+                if c == b"":
+                    break
+                s = c.decode("utf-8")
+                stdout += s
+                print(s, end="", flush=True)
+            return_code = proc.wait()
 
-        # TODO: print lines real time as the subprocess runs
-        print(result.stdout, end="")
-
-        if result.returncode:
+        if return_code:
             # failed
-            title = f"Command failed with exit code {result.returncode}"
+            title = f"Command failed with exit code {return_code}"
             if attempt < retries:
                 title += f" - Retrying (attempt {attempt+1}/{retries})"
             else:
@@ -85,26 +97,26 @@ def wrap(command: List[str], config: Path, retries: int, version):
             title = "Command succeeded"
 
         MAX_LINES = 20
-        lines = result.stdout.splitlines()
+        lines = stdout.splitlines()
+        truncated = False
         if len(lines) > MAX_LINES:
+            truncated = True
             lines = lines[-MAX_LINES:]
         message = (
-            "Command:\n"
-            + " ".join(command)
-            + f'\n\nResult{ " (truncated)" if len(lines) > MAX_LINES else ""}:\n'
-            + "\n".join(lines)
+            "Command:\n" + " ".join(command) + f'\n\nResult{ " (truncated)" if truncated else ""}:\n' + "\n".join(lines)
         )
 
-        with gotify.Gotify(base_url=url, app_token=app_token) as gotify_connection:
-            gotify_connection.create_message(message=message, title=title)
+        if not dry_run:
+            with gotify.Gotify(base_url=url, app_token=app_token) as gotify_connection:
+                gotify_connection.create_message(message=message, title=title)
 
-        if not result.returncode:
+        if not return_code:
             # only retry on failure
             break
 
         attempt += 1
 
-    sys.exit(result.returncode)
+    sys.exit(return_code)
 
 
 # %% main